Fix broken development setup #10469
Closed
Fix broken development setup #10469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes circular dependency in Makefile added in pypi#10278 Unblocks pypi#10052 Fixes pypi#10446 Fixes pypi#10447
In --require-hashes mode, all requirements must have their versions pinned with ==. These do not: pip>=20.1
ewjoachim
reviewed
Dec 14, 2021
ewjoachim
reviewed
Dec 14, 2021
On % expansion only the first dependency is passed to command line
|
@ewjoachim addressed all comments. PTAL. |
|
@di @ewjoachim @ewdurbin ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes circular dependency in Makefile added in #10278
Unblocks #10052
Fixes #10446
Fixes #10447