Update EA client to the latest non-beta version #10489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have shipped the features that were originally in our beta client for the PSF into our main client. This PR updates the client version to use the released version.
This was referenced Dec 14, 2021
|
@ewdurbin Thanks for updating this. I'm not able to reproduce the image issue you were seeing. I'm able to reproduce the image failing to load, which seems to happen because of the Acceptable Ads block list doesn't include that URL. But even when the image fails to load, it should be
|
ewdurbin
force-pushed
the
ea-client-production
branch
from
5693617
to
8088891
Compare
|
@ericholscher it boils down to our CSP blocking the ea client from adding the inline style for display: none. adding the hashes to the CSP allows that and correctly styles the pixel. |
|
@ewdurbin Gotcha, thanks for pushing this out so quickly. 🎉 |
domdfcoding
pushed a commit
to domdfcoding/warehouse
that referenced
this pull request
Jun 7, 2022
* Update EA client to the latest non-beta version We have shipped the features that were originally in our beta client for the PSF into our main client. This PR updates the client version to use the released version. * update CSP for new ethicalads client Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #10488