Use EthicalAds to display PSF sponsor logos at sponsor page #10819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merwok
reviewed
Mar 14, 2022
| <p>{{ sponsor.level_name|default("---", true) }}</p> | ||
| <label for="{{ input_id }}" class="col-sm-2 align-right">Level Order</label> | ||
| <p>{{ sponsor.level_order|default("---", true) }}</p> | ||
| <label for="{{ input_id }}" class="col-sm-2 align-right">Slug</label> |
There was a problem hiding this comment.
The four labels have the same for attribute, which seems like a bug
There was a problem hiding this comment.
But the real issue here is probably the use of labels outside of a form!
miketheman
added
the
awaiting-response
|
#13953 fixed the task, so now it's running correctly. Is this PR still desirable? |
|
@miketheman I've been away from the project for a while, but I'm 100% sure @ewdurbin can answer you better. |
|
Yeah, I think we'd want to proceed with this! |
miketheman
added
UX/UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a #10766 follow-up. Its core is the update on sponsors page to display PSF sponsors logo from EthicalAds instead of using from pypi's static images. This PR also improves sponsor detail admin by displaying the information from logo placement's API as read-only data. Here's a screen shot of how it looks like: