Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept file names with . replaced with _ #14155

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Accept file names with . replaced with _ #14155

merged 4 commits into from
Jul 19, 2023

Conversation

di
Copy link
Member

@di di commented Jul 18, 2023

Fixes #10030.

@di di requested a review from a team as a code owner July 18, 2023 17:44
@di
Copy link
Member Author

di commented Jul 18, 2023

I've filed #14156 to eventually handle the inverse of this via a deprecation period.

@di di enabled auto-merge (squash) July 19, 2023 17:50
@di di merged commit d1f6c40 into pypi:main Jul 19, 2023
14 checks passed
@di di deleted the fix/10030 branch July 19, 2023 17:56
@takluyver
Copy link
Contributor

takluyver commented Jul 20, 2023

I think there's a corner case where this could go wrong with a project name like foo..bar or foo._bar. The spec says this normalises to foo_bar, but I think this implementation will give foo__bar (double underscore). If the wheel filename is already normalised, it won't match, so the upload would incorrectly be rejected.

This is probably pretty academic, though - I doubt anyone wants to use a name like that.

@di
Copy link
Member Author

di commented Jul 20, 2023

@takluyver Good call! See #14172 which should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyPI does not accept wheel file name with . replaced with _
3 participants