Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unchecked GitLab claims #15466

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Add unchecked GitLab claims #15466

merged 2 commits into from
Feb 23, 2024

Conversation

di
Copy link
Member

@di di commented Feb 23, 2024

@di di requested a review from a team as a code owner February 23, 2024 15:50
@di di mentioned this pull request Feb 23, 2024
Closed
2 tasks
woodruffw
woodruffw approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

(Thinking out loud: the TOFU idea for namespace_id would also probably work for project_id: leave them unpopulated at publisher creation time, and then populate them based on claim values on first use. But that's an additional complexity.)

@di di merged commit 8155a65 into pypi:main Feb 23, 2024
17 checks passed
@di di deleted the add-unchecked-gitlab-claims branch February 23, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw woodruffw approved these changes

@miketheman miketheman miketheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@di @miketheman @woodruffw