-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove depot/setup-action with.oidc #15632
Conversation
@jacobwgillespie Thanks! Seeing these in this run's log:
It still succeeds, but is this still trying to do something and times out? |
Hey yeah those logs are somewhat expected (I need to silence the initial error) - the way OIDC works for external PR workflows is that a challenge token is printed to the logs then the OIDC issuer connects to the workflow log stream and verifies the token value is being printed. The initial error can be ignored, I need to fix the action so it doesn't print it |
Thanks @jacobwgillespie ! I'm noticing it kinda spin on that step, and take ~3-4 minutes to continue - which drives up CI times. Is that also something that will be addressed soon? |
Looks like this removal had other negative impact on other steps? https://github.com/pypi/warehouse/actions/runs/8346865483/job/22845432075 |
Looks like we're trying to pass the output of warehouse/.github/workflows/ci.yml Lines 37 to 39 in 4b94bfe
But it's empty now, causing this to fail: warehouse/.github/workflows/ci.yml Lines 63 to 66 in 4b94bfe
|
Maybe only sometimes? Seems to have worked fine for #15631. |
This removes the
with.oidc
option from thedepot/setup-action
- the Depot CLI should now natively handle this for public PRs ✨