chore: enforce 2fa for legacy uploaders #16365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disallow uploads if the token from a user account does not have 2FA. - Add `UserFactory` trait to simplify email creation in test cases - Update test coverage for `repeat_window` to exercise logic independent of email-specific test cases - Remove email template Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
added
security
|
Here's a chart showing the dropoff over time. 
|
woodruffw
reviewed
Jul 30, 2024
miketheman
commented
Jul 30, 2024
| @@ -226,6 +226,49 @@ def test_doesnt_send_within_reset_window(self, pyramid_request, pyramid_services | |||
| assert pyramid_request.task.calls == [] | |||
| assert task.delay.calls == [] | |||
|
|
|||
| def test_sends_when_outside_repeat_window(self, db_request, pyramid_services): | |||
There was a problem hiding this comment.
I had to add this test case since the repeat_window logic wasn't exercised directly, only via another email template test.
dstufft
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallow uploads if the token from a user account does not have 2FA.
UserFactorytrait to simplify email creation in test casesrepeat_windowto exercise logic independentof email-specific test cases
Signed-off-by: Mike Fiedler miketheman@gmail.com