-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(admin): set primary email after recovery complete #16516
feat(admin): set primary email after recovery complete #16516
Conversation
If the Account Recovery process has an email that is to be used during the process, 'activate' it at the end once completed. Resolves pypi#16401
I think this fits the need. One thought that I hadn't really considered is if we should skip password/2FA reset in these conditions. My understanding is that generally this state occurs when someone has their password/2FA but has lost access to the original primary email address. @Thespi-Brain, do you have any input here? |
@ewdurbin I think we should still keep the password/2FA reset because there have been cases where 2FA was not set up in addition to the user not having access to their original primary email address. It's also nice to have a "clean" reset for due diligence and security. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Thespi-Brain I am assuming that for situations where users still control their password/2FA, we will update their email address without the account recovery process leading to resetting password/2FA. If so this is good to go.
@ewdurbin Yes, we don't go through the account recovery process for an email update if the user doesn't have any existing projects. |
If the Account Recovery process has an alternate email that is to be used during the process, 'activate' it at the end once completed.
Resolves #16401