Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verified GitHub stats #16532

Merged
merged 11 commits into from
Aug 21, 2024
Merged

Verified GitHub stats #16532

merged 11 commits into from
Aug 21, 2024

Conversation

di
Copy link
Member

@di di commented Aug 20, 2024

This PR moves the "GitHub Statistics" into the "Verified details" section if we have a verified GitHub URL. It does not display the statistics section if there is not a verified URL:

Before After
Screenshot 2024-08-20 at 7 48 13 PM Screenshot 2024-08-20 at 7 46 35 PM

It also adds a link to the repository in the Statistics section and fixes some errant styling in the unverified section.

Fixes #14727, closes #10917.

@di di requested a review from a team as a code owner August 20, 2024 23:52
Copy link
Member

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally fine, a couple of comments on tests and style.

tests/unit/packaging/test_models.py Outdated Show resolved Hide resolved
warehouse/static/sass/blocks/_verified.scss Outdated Show resolved Hide resolved
@miketheman miketheman added UX/UI design, user experience, user interface HTML requires change to HTML files CSS/SCSS requires change to CSS/SCSS files labels Aug 21, 2024
@di
Copy link
Member Author

di commented Aug 21, 2024

OK, here's an updated screenshot with the requested changes made:

image

@di di requested a review from miketheman August 21, 2024 16:52
Copy link
Member

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's goooo

@di di merged commit 24fca7f into pypi:main Aug 21, 2024
18 checks passed
@di di deleted the verified-github-stats branch August 21, 2024 17:23
@MartinThoma
Copy link

Thanks for taking care of this 🙏

Is the verification mechanism described somewhere? Or could you point me to where I can see that in the code 😅

@di
Copy link
Member Author

di commented Aug 21, 2024

See https://docs.pypi.org/project_metadata/

ewdurbin added a commit that referenced this pull request Sep 18, 2024
Introduced in #16532, this made the hit box around links in the vertical-tab bar overlap.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS/SCSS requires change to CSS/SCSS files HTML requires change to HTML files UX/UI design, user experience, user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project Details Sidebar Statistics behavior Show repository name, in the GitHub statistics section
3 participants