-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verified GitHub stats #16532
Verified GitHub stats #16532
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally fine, a couple of comments on tests and style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's goooo
Thanks for taking care of this 🙏 Is the verification mechanism described somewhere? Or could you point me to where I can see that in the code 😅 |
Introduced in #16532, this made the hit box around links in the vertical-tab bar overlap.
This PR moves the "GitHub Statistics" into the "Verified details" section if we have a verified GitHub URL. It does not display the statistics section if there is not a verified URL:
It also adds a link to the repository in the Statistics section and fixes some errant styling in the unverified section.
Fixes #14727, closes #10917.