Revert "Store attestations for PEP740 (#16302)" #16545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewdurbin
approved these changes
Aug 21, 2024
woodruffw
added a commit
to trail-of-forks/warehouse
that referenced
this pull request
Aug 21, 2024
This reverts commit da7e1ed.
ewdurbin
pushed a commit
that referenced
this pull request
Sep 3, 2024
* Reapply "Store attestations for PEP740 (#16302)" (#16545) This reverts commit da7e1ed. * migrations: re-roll migration history Signed-off-by: William Woodruff <william@trailofbits.com> * config: register .attestations for inclusion Signed-off-by: William Woodruff <william@trailofbits.com> * attestations: request the appropriate IFileStorage service IFileStorage requires a name to disambiguate it. Signed-off-by: William Woodruff <william@trailofbits.com> * conftest: add archive_files.path to get_app_config Signed-off-by: William Woodruff <william@trailofbits.com> * test, warehouse: remove problematic mocks This removes two mocked `db_request`s from the simple index tests. These mocks were masking larger architectural issues with both attestations and our test scaffolding for attestations. This isn't quite complete yet, since it does a nasty thing (uses a file storage with a tmpdir) to get IntegrityService initialization working. Signed-off-by: William Woodruff <william@trailofbits.com> * test_services: rename test class Signed-off-by: William Woodruff <william@trailofbits.com> * Try to clean a bit the mess with the migrations. * begin refactoring IntegrityService This reduces the overall API surface for IIntegrityService implementers, and adds an initial NullIntegrityService to make unit-level testing simpler. Signed-off-by: William Woodruff <william@trailofbits.com> * Revert "Try to clean a bit the mess with the migrations." This reverts commit e19be6c. * tests, warehouse: more error tests, remove more stubs Signed-off-by: William Woodruff <william@trailofbits.com> * test_services: fix match Signed-off-by: William Woodruff <william@trailofbits.com> * remove more implicit file service deps Signed-off-by: William Woodruff <william@trailofbits.com> * continue to burn down coverage Remove more ad-hoc stubs as well. Signed-off-by: William Woodruff <william@trailofbits.com> * full coverage Signed-off-by: William Woodruff <william@trailofbits.com> * test_simple: positive provenance test for /simple Signed-off-by: William Woodruff <william@trailofbits.com> * tests: minimize, increase confidence in behavior Signed-off-by: William Woodruff <william@trailofbits.com> * Update warehouse/config.py Co-authored-by: dm <darkamaul@hotmail.fr> * packaging/test_utils: remove another mock Signed-off-by: William Woodruff <william@trailofbits.com> * Remove even more mocks * Update tests/conftest.py Co-authored-by: William Woodruff <william@yossarian.net> * Update test_create_service * Add a functional test * Linting * Fixup migration * Fix test error * Revert change * Apply suggestions from code review Rename key Co-authored-by: Dustin Ingram <di@users.noreply.github.com> * Revert "Apply suggestions from code review " This reverts commit 52931a1. * Give the IntegrityService access to the session * Add the Attestation object to the session * Update the functional test with more assertions * Remove vestigial helper * Update functional test --------- Signed-off-by: William Woodruff <william@trailofbits.com> Co-authored-by: Alexis <alexis.challande@trailofbits.com> Co-authored-by: dm <darkamaul@hotmail.fr> Co-authored-by: Dustin Ingram <di@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5545884.