-
Notifications
You must be signed in to change notification settings - Fork 980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support PEP-740 attestations for GitLab CI/CD #17125
Conversation
Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
|
944fb69
to
42462d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work @facutuesca!
Flagging one thing (could be done now or in a follow-up): the warehouse/warehouse/templates/includes/file-details.html Lines 15 to 24 in dde8b3d
|
Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
42462d5
to
72a62a8
Compare
Good catch, fixed! |
Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
Opened PR for the docs here: #17133 |
Adds support for uploading PEP-740 attestations generated from a GitLab CI/CD workflow.
The actual verification is done inside
pypi-attestations
, similar to GitHub.Tested locally with an attestation signed from GitLab CI/CD:
Rekor entry: https://search.sigstore.dev/?logIndex=149980684
Part of #17001
cc @woodruffw @di