allow for overriding cache decorator ttl on response #18101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is primarily to support discriminating between HTML and JSON rendered /simple/ index cache times. In support of pypa/bandersnatch#1898
Contributor
|
I don't know if this is possible, but could we reduce the TTL for only bandersnatch clients so others get what they get today and only bandersnatch get's lower and maybe lower than 1 hour? I get this could be a DOS/DDOS enabling feature, but isn't the xmlrpc endpoint today anyways?
|
di
approved these changes
May 8, 2025
Member
Author
Not necessary since this should only result in one request to the backend every 30 minutes or so. The response will be be cached in our CDN. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily to support discriminating between HTML and JSON rendered /simple/ index cache times.
In support of pypa/bandersnatch#1898