feat: look up custom issuers by inbound URL #18892
Open
+110
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When receiving an inbound JWT, handle cases where the inbound issuer is not one of the "standard" service URLs, such as in the case of GitLab Self-Managed or GitHub Enterprise Server instances. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
commented
Oct 16, 2025
|
|
||
| # Associate the given issuer claim with Warehouse's OIDCPublisherService. | ||
| # First, try the standard issuers | ||
| service_name = OIDC_ISSUER_SERVICE_NAMES.get(unverified_issuer) |
There was a problem hiding this comment.
If nobody ever uses a custom issuer, there's no lookup penalty, since it'll match the static dictionary value. This should be the case for most lookups.
ewdurbin
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When receiving an inbound JWT, handle cases where the inbound issuer is not one of the "standard" service URLs, such as in the case of GitLab Self-Managed or GitHub Enterprise Server instances.
Refs: #18865
Calling
PendingGitLabPublisher.reify()with a customissuer_urlhas not been implemented yet.