Project Settings / Delete Project

[di]

Fixes #2805. This moves the releases to their own route, and stubs out an "options" page with a basic form for project deletion.

(cc @nlhkabu)

[nlhkabu]

Awesome, thanks @di!
I will pull it down and take a look :)

[nlhkabu]

Hi @di, I've pushed up some changes in light of the new structure.

I've noticed that I'm getting an error on the collaborators page:

Could you please take a look.

This is almost ready to merge on my side - I just need to look at the mobile UI.

[di]

@nlhkabu Sorry about that, fixed now!

[nlhkabu]

Thanks @di - I'll fix the rest of the UI tomorrow, so hopefully we can merge :)

[nlhkabu]

This page is now done from a style POV on both mobile and desktop:

Still a bit ugly on mobile:

• Projects page (list of projects)
• Releases table
• Collaborators table

I suggest we merge this PR and I can open a new one to address these, as well as #2838

What do you think @di?

[nlhkabu]

Ok, rebased with master, so we should be ready to go 😁

One thing I noticed in the templates:

<div class="package-snippet__buttons">
  <a href="{{ request.route_path('manage.project.releases', project_name=project.normalized_name) }}" class="button button--primary">Edit</a>
  <a href="{{ request.route_path('packaging.project', name=project.normalized_name) }}" class="button">View</a>
</div>

Is there a good reason why one is project_name=blah while the other is project=blah ?

[di]

I suggest we merge this PR and I can open a new one to address these, as well as #2838

Sounds fine to me!

Is there a good reason why one is project_name=blah while the other is project=blah ?

Yeah, I changed all of the manage routes to take a project_name instead so I can reuse the confirm_project and delete_project utility functions that we already have on the admin side of things. All the admin routes took a project_name instead of just name and I figured that the former was less ambiguous.

It's probably worth updating all the packaging routes to take a project_name instead as well, but since it's not really necessary for this PR, I left it for later.

[di]

I made a small tweak here to match the new "Edit Project" button, which is that "Project Settings" is the first item in the menu, and the default when you press the "Edit" button on the list of projects.

We should fix #2418 (via #2849) before merging this, so that deleting a project purges the cache.

[nlhkabu]

Hi @di - I agree that the 'edit' button should go to the same place, but I'm not sure that I agree that the 'settings' page is the best landing page?

At the moment the only thing on there is to delete a project, which we want to "hide" as much as possible in the UI.

What is the most common action a project owner/maintainer will want to do? Look at / edit their releases, manage their collaborators, or change the settings? Maybe we can get this information from the current site analytics?

[di]

@nlhkabu Great point. I changed this back to make the "releases" page the default, and we can reevaluate the ordering later if need be.

[nlhkabu]