Return empty response when include fails #2846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the client side include fails for some reason, return an empty response. For example, if there is a permissions error, don't redirect to the login page, just show an empty view.
di
force-pushed
the
fix-edit-project-button-include
branch
from
31372c6
to
ea0844d
Compare
dstufft
reviewed
Jan 26, 2018
|
|
||
| resp = forbidden_include(exc, request) | ||
|
|
||
| assert resp.status_code == 200 |
There was a problem hiding this comment.
Do we still want this to be a 403 response? I think the HTML include will work fine in either case, but it feels a little cleaner to keep the response code as 403 here? What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2843.
If the client side include fails for some reason, return an empty response. For example, if there is a permissions error, don't redirect to the login page, just show an empty view.