Destroy documentation #3413
Merged
Destroy documentation #3413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dstufft
reviewed
Mar 25, 2018
warehouse/utils/project.py
Outdated
|
|
||
| project.has_docs = False | ||
| # Flush so we can repeat this multiple times if necessary | ||
| request.db.flush() |
There was a problem hiding this comment.
Do we really need a flush here? That really surprises me that it's required.
There was a problem hiding this comment.
eh, probably not, definitely just copy pasta :)
dstufft
approved these changes
Mar 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #582
Only displays admin tab for projects which have documentation on pythonhosted.org
I'm going to spot check the bucket and our DB and make sure it's in sync before we deploy
Requires new configurationNew configuration added:test.pypi.org
pypi.org