-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update links to distutils-sig from pypa-dev #8028
Conversation
…ls-sig mailing list instead
You're welcome, and congrats on making your first pull request ever! Am reviewing now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I am having trouble with my local Warehouse environment so I was not able to test make docs
but I believe this should be fine.
Thanks for writing a descriptive commit message. Here's a guide to help you write commit messages that are more consistent with general commit message style style, which makes it easier for us in the future -- when someone's trying to solve a new problem, if commit messages are all in the same format, it's easier to skim them in logs and quickly understand what's happening. Here are some tips on tidying your commit history, including changing your commit messages. And when you update your code or your commit message, you can update your pull request and the changes will appear here. :) |
@arshadrr If you'd like a suggestion for your SECOND issue to work on, comment here and say so. :-) Thanks again. |
@brainwane Sure, I'd like that. |
@brainwane Oh, and I think the two links in the second paragraph of the comment you made about commit messages might have moved. |
Thanks for that heads-up. I need to update and fix my Saved Replies, clearly. |
This PR replaces references to the decomissioned pypa-dev google group with the distutils-sig mailing list. Closes #8012 . Thanks @brainwane for the approachable first issue :)