Fixups for admin SponsorLogo upload. #9794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
added resolutions to comments from #9792 (review) |
ewdurbin
changed the title
ewjoachim
reviewed
Jul 15, 2021
| sponsor_name = slugify(form.name.data) | ||
| if request.POST.get("white_logo") not in [None, b""]: | ||
| if request.POST.get(image_name) not in [None, b""]: |
There was a problem hiding this comment.
(slight remark, but this is more simply expressed as if request.POST.get(image_name):, no ?)
ewjoachim
reviewed
Jul 15, 2021
| fingerprint = secrets.token_urlsafe(6) | ||
| filename = f"{sponsor_name}-{slugify(image_name)}-{fingerprint}{extension}" | ||
| return storage.store(filename, fp.name) | ||
| return "" |
There was a problem hiding this comment.
Wouldn't return None be more explicit ? (or an exception)
domdfcoding
pushed a commit
to domdfcoding/warehouse
that referenced
this pull request
Jun 7, 2022
* ensure prefix is applied for GCSSponsorLogoStorage * lint * sponsor logos: deduplicate upload code, fingerprint uploads * my first walrus * fix coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.