Use logo placement server to place sidebar's logos #9979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewdurbin
reviewed
Sep 7, 2021
…able to EthicalAds script
berinhard
force-pushed
the
topic/sidebar-logo-placement
branch
from
41ecf4b to
03e4530
Compare
|
@ewjoachim and @ewdurbin this PR is ready for a final review and merge once PSF have it all ready with EthicalAds. |
ewdurbin
approved these changes
Nov 11, 2021
ewdurbin
added a commit
that referenced
this pull request
Nov 16, 2021
Follows on from #9979 - Updates CSP for connect-src used for placement view reporting - Tweaks CSS to better style/differentiate logo placement
ewdurbin
added a commit
that referenced
this pull request
Nov 16, 2021
Follows on from #9979 - Updates CSP for connect-src used for placement view reporting - Tweaks CSS to better style/differentiate logo placement
ewdurbin
added a commit
that referenced
this pull request
Nov 17, 2021
Follows on from #9979 - Updates CSP for connect-src used for placement view reporting - Tweaks CSS to better style/differentiate logo placement
domdfcoding
pushed a commit
to domdfcoding/warehouse
that referenced
this pull request
Jun 7, 2022
* Update hashes * Update CSP to accept etihcaldas script * Update breaking test for past date * Replace db logo placement by test one * Add integrity check * Update sha * Use pinned version for logo placement server * Add hashes for inline files * Use random ad from sidebar * Use direct include instead async request so the sponsors div is available to EthicalAds script * Update publisher ID * Update sponsor logo placement to use base side bar section class * Better display sponsor logo * Add new hashes to CSP tests * Try to pass on static lint build * Make translations Co-authored-by: Ee Durbin <ewdurbin@gmail.com>
domdfcoding
pushed a commit
to domdfcoding/warehouse
that referenced
this pull request
Jun 7, 2022
Follows on from pypi#9979 - Updates CSP for connect-src used for placement view reporting - Tweaks CSS to better style/differentiate logo placement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates pypi to use logo placement server to place logo instead of the sponsors db.
To enable it, we had to update our CSP policies to include not only the server but also the hashes from JS and style files used. To better fit the logo in the sidebar, there's a minor CSS customization to support it. Here's a print screen of the final result: