Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable some sensors by default #236

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

jschlyter
Copy link
Collaborator

@jschlyter jschlyter commented Nov 13, 2024

Sensors not useful for most people should be disabled by default:

  • internal_vehicle_id
  • factory_complete
  • registration_date
  • api_status_code_auth
  • api_status_code_data
  • api_token_expires_at

@jschlyter jschlyter requested a review from a team as a code owner November 13, 2024 19:25
@BJReplay
Copy link

BJReplay commented Nov 13, 2024

As a pending owner, who has ordered, not received the vehicle, but has the VIN, factory_complete is one of the few fields that is available with data before I receive the vehicle, so is very useful!

Perhaps add it late when creating so it sorts to the bottom of list, but disable?

I am also monitoring registration date as that will allow me to know that I should pay for insurance!

@jschlyter
Copy link
Collaborator Author

As a pending owner, who has ordered, not received the vehicle, but has the VIN, factory_complete is one of the few fields that is available with data before I receive the vehicle, so is very useful!

Perhaps the factory completion date should be an attribute of the VIN and the registration date an attribute of the registration number? They never change, but are still valuable.

@BJReplay
Copy link

Perhaps the factory completion date should be an attribute of the VIN and the registration date an attribute of the registration number?

Absolutely.

They never change, but are still valuable.

Well, rarely :) anyway. Registration could change if the vehicle is sold, but presumably the ownership of the VIN will change, but yeah, attributes is a great solution.

@jschlyter
Copy link
Collaborator Author

@BJReplay, dates as attributes now in #238

@jschlyter
Copy link
Collaborator Author

My plan is to to merge this PR as is, and mention in the next release notes that factory_complete and registration_date will be removed as sensors in the release after the next.

@jschlyter jschlyter merged commit fdf5a76 into pypolestar:main Nov 18, 2024
3 checks passed
@jschlyter jschlyter deleted the default_disabled branch November 18, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants