ENH: Add inplace kwarg to Geod.fwd and Geod.inv #1201
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to reuse the arrays passed in and out of the geod functions, following the same idea as the Transformers. I noticed this while profiling some of Cartopy's code and we could potentially get some speedup over there from this. We spend a lot of time in
_copytobuffer
.I'm not sure if you would want the inplace applied to all potential inputs (i.e.
ind
as well) or just the outputs. Seems best to make it all to avoid the copy if possible.history.rst
for all changes andapi/*.rst
for new API