Add deprecation warnings for get_units_map and get_angular_units_map #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
snowman2
commented
Apr 30, 2020
•
snowman2
commented
- Related to units changes in PROJ 7.1.0 #599 (Add proj_get_units_from_database() (fixes #2004) OSGeo/PROJ#2065)
- Tests updated
| @@ -74,6 +75,12 @@ def get_units_map(): | |||
| dict: | |||
| Units supported by PROJ | |||
| """ | |||
| warnings.warn( | |||
| "The behavior of 'pyproj.get_units_map' is deprecated " | |||
| "and will change in version 3.0.0.", | |||
There was a problem hiding this comment.
Small comment: it's not very clear what the consequence of this is: what will change? What should the user do instead when seeing this warning?
There was a problem hiding this comment.
The user really cannot do much here as the change will just happen. The exact change isn't 100% decided, but will definitely be different.
There was a problem hiding this comment.
Then it is maybe a bit too soon to raise a warning? As this will just be confusing, I might think
There was a problem hiding this comment.
Well, I wanted to have something. Not sure if there are going to be any more 2.x releases after this next one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.