Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary imports #1020

Merged
merged 4 commits into from
May 3, 2024
Merged

remove unnecessary imports #1020

merged 4 commits into from
May 3, 2024

Conversation

finozzifa
Copy link
Contributor

@finozzifa finozzifa commented May 2, 2024

Closes # (if applicable).

Changes proposed in this Pull Request

The purpose of this PR is to remove all the imports present in the scripts/ folder that are not actually in use

Checklist

  • [x ] I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • [x ] I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @finozzifa :D
That's a very nice PR and soon ready to merge.

As additional element, the "import logging" should in theory be dropped everywhere except the helpers.
To me it seems that remains in build_powerplants for an old missing dependencies (see comment into the file) and also into build_cutout because we have an old "logging.info/warning" that should be revised into "logger.info/warning"
Could you check that?
After that, the PR can be merged :D

@@ -69,7 +69,7 @@
tutorial: # configuration stating whether the tutorial is needed


.. seealso::
.. see also::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a keyword, can you revert?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Davide. Thanks :)

scripts/build_powerplants.py Show resolved Hide resolved
Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @finozzifa :D
This PR is ready to go :)

@davide-f davide-f merged commit f5af140 into pypsa-meets-earth:main May 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants