-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unnecessary imports #1020
remove unnecessary imports #1020
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @finozzifa :D
That's a very nice PR and soon ready to merge.
As additional element, the "import logging" should in theory be dropped everywhere except the helpers.
To me it seems that remains in build_powerplants for an old missing dependencies (see comment into the file) and also into build_cutout because we have an old "logging.info/warning" that should be revised into "logger.info/warning"
Could you check that?
After that, the PR can be merged :D
scripts/retrieve_databundle_light.py
Outdated
@@ -69,7 +69,7 @@ | |||
tutorial: # configuration stating whether the tutorial is needed | |||
|
|||
|
|||
.. seealso:: | |||
.. see also:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a keyword, can you revert?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Davide. Thanks :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great @finozzifa :D
This PR is ready to go :)
Closes # (if applicable).
Changes proposed in this Pull Request
The purpose of this PR is to remove all the imports present in the scripts/ folder that are not actually in use
Checklist
envs/environment.yaml
anddoc/requirements.txt
.config.default.yaml
andconfig.tutorial.yaml
.test/
(note tests are changing the config.tutorial.yaml)doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.