Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namibia geofk #1330

Merged
merged 6 commits into from
Feb 4, 2025
Merged

Conversation

davide-f
Copy link
Member

@davide-f davide-f commented Feb 2, 2025

Closes # (if applicable).

Changes proposed in this Pull Request

  • Fixes "NA" not found in earth-osm
  • Drops warning of future unsupported "H" option in favour of "h" for opts
  • Drop country tag for lines that sometimes lead to errors in the clustering phase

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@davide-f davide-f merged commit 1481c42 into pypsa-meets-earth:main Feb 4, 2025
7 checks passed
@davide-f
Copy link
Member Author

davide-f commented Feb 4, 2025

@arizeosalac this PR should have fixed the issue about assertion error during clustering where country codes mismatched :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant