-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement HVDC lines into the model #348
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ekatef thanks for the contribution.
I added few minor recommendations.
Before merging, I think it is appropriate if you could also share the plots of the comparison between the networks (raw osm data, clean osm_data and simplify network) with the current version for countries where AC/DC lines.
After clean osm, it would be nice to differentiate between links and lines and see what happens.
A zoom may be in handy close to a station to check how components are connected.
What do you think? Those plots could be done using the already available validation plots or also using the code you have already used for the past images
@davide-f, thanks for checking! I love your idea regarding the visual checks. Actually, a combination of a static big-picture plot and hvplot zooms gives excellent options to explore the grid structure. I have been playing with such visualisations which was quite funny :) Then I'll repeat these tests on the the revised code and share the results. Do you think it's appropriate to attach them to a PR or would it be better to create a notebook for that? |
I crosschecked the comments again. |
for more information, see https://pre-commit.ci
The PR implies some changes in the network topology which makes it necessary to compare the resulted network with ones from the current main branch where DC lines are treated as AC. Results of the graphical topology check on CD look as follows. on raw dataBoth approaches give the identical results on clean dataBlue = AC, red = DC, thickness is set according to the voltage original approachAll DC lines were transformed to AC ones. tested aproachon
|
@davide-f, could you please have a look? I think most of the issues should be fixed now. Although, I have broken the CI (sorry for that!) but it seems to be related to some minor troubles in access to |
Don't be sorry for the CI, it happens often, the CI works is not broken with that error :) super! To me, the images look very fine; I think we are super close to merge this PR. Few questions:
|
Thank you, @davide-f :)
Yes, the converters and buses are red while both AC and DC lines are blue. I'll work to improve the colour scheme for further use as hvplot seems to provide fantastic options for grid visualisations.
I think that's a switching station at Kananga city and the bus should be connected to a distribution network. There are a few similar structures along the Inga–Shaba line. |
No need, I was just asking to crosschecking, perfect! no need to have more images :)
Ok! My thought was why in the other approach there was no such a bus, but from the point of view of the network the network seems to keep the connections. Can you confirm that? |
In the original approach there is a bus also (close to the center of this X-shape) but it's poorly visible on the picture... Have checked connectivity manually and not found any problems. It seems that PR is really working. Thank you so much for your support :) |
@ekatef Great work! This PR has been merged. |
Wonderful, thank you! Now it looks for me absolutely doable :) |
Implement HVDC lines into the model
…_percent_2 Add Params to build_population_layout
The PR is intended to resolve #286 using the following approach proposed by @davide-f (thank you for the brilliant tutorial!)
TODOs
merge_stations_lines_by_station_id_and_voltage( )
works properly for links (build_osm_network
script)"dc"
column of the buses csv (build_osm_network
script)base_network
script)p_nom_max
(base_network
script)Checklist
envs/environment.yaml
andenvs/environment.docs.yaml
.config.default.yaml
,config.tutorial.yaml
, andtest/config.test1.yaml
.doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.