-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate hydro capacities #366
Conversation
I've validated the hydro energy production; I may modify an existing script to show that. Any opinions? |
I think this PR is in very good shape. That can be done in this PR or a new one, however, it is important to review the current PR that has the following new features:
|
@davide-f cool that you also repaired the CI :D
Can you add a release_note? Further, can you create a new issue that addresses "Add hydro inflow normalization" or something like that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
release note missing
Release note added and opening the new issue |
Awesome 👯 |
Closes #39 and #108
Changes proposed in this Pull Request
Validate and improve hydro representation
Checklist
envs/environment.yaml
andenvs/environment.docs.yaml
.config.default.yaml
,config.tutorial.yaml
, andtest/config.test1.yaml
.doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.