Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate hydro capacities #366

Merged
merged 25 commits into from
Jun 7, 2022
Merged

Validate hydro capacities #366

merged 25 commits into from
Jun 7, 2022

Conversation

davide-f
Copy link
Member

@davide-f davide-f commented Jun 3, 2022

Closes #39 and #108

Changes proposed in this Pull Request

Validate and improve hydro representation

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@davide-f davide-f changed the title Validate hydro Validate hydro capacities Jun 3, 2022
@davide-f
Copy link
Member Author

davide-f commented Jun 5, 2022

With the latest fix, now inflows are non-zero for all powerplants in NG (tested for the dams or storage_units)
image

@davide-f
Copy link
Member Author

davide-f commented Jun 5, 2022

I've validated the hydro energy production; I may modify an existing script to show that.
Currently, the solution for Nigeria leads to 5.56TWh of energy production. According to IEA, in 2013 (we use the cutout of 2013), the hydro energy production was 19174 TJ (https://www.iea.org/countries/nigeria) which are 5.33TWh.
I think we can consider almost finalized this problem.

Any opinions?

@davide-f davide-f linked an issue Jun 5, 2022 that may be closed by this pull request
@davide-f davide-f marked this pull request as ready for review June 7, 2022 12:09
@davide-f
Copy link
Member Author

davide-f commented Jun 7, 2022

I think this PR is in very good shape.
As you can see in the new hydro notebook, total energy production by hydro does not match the expected value (130TWh vs our 77TWh), the error is too large.
With respect to PyPSA-Eur, we do not do the inflow normalization, which may be needed and I think it is just the missing step.

That can be done in this PR or a new one, however, it is important to review the current PR that has the following new features:

  • Improved hydro_capacities
  • Validation notebook for hydro energy production
  • Crosscheck and bugfixing for hydro energy production
  • Other minor bug fixing

@davide-f davide-f requested a review from pz-max June 7, 2022 12:13
@pz-max
Copy link
Member

pz-max commented Jun 7, 2022

@davide-f cool that you also repaired the CI :D
Great validation script. Yes, we are slightly off +-40%...
Before I am merging this PR due to other useful corrections happening:

  • crs addition, snakemake fix, default.config fix

Can you add a release_note?

Further, can you create a new issue that addresses "Add hydro inflow normalization" or something like that?

Copy link
Member

@pz-max pz-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release note missing

@davide-f
Copy link
Member Author

davide-f commented Jun 7, 2022

Release note added and opening the new issue

@pz-max pz-max merged commit f2e7288 into pypsa-meets-earth:main Jun 7, 2022
@pz-max
Copy link
Member

pz-max commented Jun 7, 2022

Awesome 👯

@davide-f davide-f deleted the validate-hydro branch June 9, 2022 22:45
pz-max added a commit that referenced this pull request Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build_renewable_profiles - offwind/hydro bugs Integrating hydro reservoir capacities
2 participants