Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operational reserves margins #399

Merged
merged 7 commits into from
Jul 4, 2022
Merged

Add operational reserves margins #399

merged 7 commits into from
Jul 4, 2022

Conversation

pz-max
Copy link
Member

@pz-max pz-max commented Jul 2, 2022

Closes #321

Changes proposed in this Pull Request

This PR adds operational reserve margins from PyPSA-Eur as described here: #395

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@pz-max
Copy link
Member Author

pz-max commented Jul 2, 2022

@fneum @FabianHofmann thanks for the awesome work. Just to track some changes compared to your changes:

  • I add configtables for the new options
  • I set the default of contingency to 0 as the contingency is highly dependent on the region of interest e.g. 4000 MW contingency is too high for modelling Croatia only.
  • I activate the operational reserve margin in the CI run so that it will be tested

Maybe some of it can be reused in PyPSA-Eur?

@pz-max
Copy link
Member Author

pz-max commented Jul 2, 2022

@davide-f I changed the main branch to be protected, meaning we need at least one review before merging.

@pz-max pz-max requested a review from davide-f July 3, 2022 13:50
Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! :D

config.default.yaml Show resolved Hide resolved
@pz-max pz-max merged commit 4d7174a into pypsa-meets-earth:main Jul 4, 2022
@pz-max pz-max deleted the reserves branch July 4, 2022 08:03
pz-max added a commit that referenced this pull request Sep 24, 2022
Add operational reserves margins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add operational reserve analog to PyPSA-EUR and GenX
2 participants