Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config #463

Merged
merged 5 commits into from
Sep 28, 2022
Merged

Fix config #463

merged 5 commits into from
Sep 28, 2022

Conversation

DeniseGiub
Copy link
Contributor

@DeniseGiub DeniseGiub commented Sep 28, 2022

Changes proposed in this Pull Request

The executing of Snakemake did not work, resulting in an error in "solve all networks". I found there was a problem inside "config.default", since in line 299 the "Monte-Carlo" was set to "true" but I changed it into "false".

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@DeniseGiub DeniseGiub changed the title change Fix config Sep 28, 2022
@DeniseGiub DeniseGiub marked this pull request as ready for review September 28, 2022 11:27
Comment on lines 31 to 40

* Fix minor validation notebook inaccuracy: `PR #332 <https://github.com/pypsa-meets-earth/pypsa-earth/pull/332>`__

* Make clean_osm_data script work with land-locked country: `PR #341 <https://github.com/pypsa-meets-earth/pypsa-earth/pull/341>`_

* Add demand validation notebook for 2030 prediction `PR #344 <https://github.com/pypsa-meets-earth/pypsa-earth/pull/344>`_

* Revise build_powerplants with new version of powerplantmatching: `PR #342 <https://github.com/pypsa-meets-earth/pypsa-earth/pull/342>`_

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably removed by accident. Could you add this again?

@pz-max pz-max merged commit d36b92d into pypsa-meets-earth:main Sep 28, 2022
@DeniseGiub DeniseGiub deleted the config-fix branch January 24, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants