Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create scenario management #577

Merged
merged 8 commits into from
Jan 24, 2023

Conversation

davide-f
Copy link
Member

Changes proposed in this Pull Request

Add the scenario management in agreement to the implementation by pypsa-eur

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@davide-f davide-f force-pushed the create_scenario_management branch from f72d711 to e28c713 Compare January 23, 2023 22:33
@davide-f davide-f requested a review from pz-max January 23, 2023 22:36
@davide-f
Copy link
Member Author

@pz-max as the CI works this PR should be ready to be tested; if it fails, tomorrow rerun the failed jobs

Snakefile Show resolved Hide resolved
@davide-f davide-f force-pushed the create_scenario_management branch from 396b0c2 to a5d462a Compare January 24, 2023 08:17
Copy link
Member

@pz-max pz-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@pz-max pz-max merged commit 03d8dab into pypsa-meets-earth:main Jan 24, 2023
@davide-f
Copy link
Member Author

@Hazem-IEG FYI this PR should not be breaking for pypsa-earth-sec: the tutorial version is backward compatible but it can have strong implications for the snakefile structure in pypsa-earth-sec

@davide-f davide-f added this to the Country-wise model milestone Feb 1, 2023
@davide-f davide-f deleted the create_scenario_management branch March 16, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants