-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix build_powerplants FuelType #754
fix build_powerplants FuelType #754
Conversation
Thanks Tom, I think we should not remove the not working part but fix the original logic... see above comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made the changes necessary to the functions so that when Natural Gas is the fuel it will apply OCGT or CCGT instead of steam turbine or combustion engine and when OCGT or CCGT is the tech it will turn the fuel into Natural Gas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edited.
It looks good. Please consider the mask vs where replacement. This whole != and working principle of .where is a bit confusing. Not sure how you felt.
Can you share a screenshot of how the data looks now with the fixes?
@Tomkourou thanks. Will be merged after it runs through |
Closes # (if applicable).
Changes proposed in this Pull Request
Removes the Gas transformations in build_powerplants as they don't seem necessary any longer. Tested on Egypt and tutorial countries and works well.
Checklist
envs/environment.yaml
anddoc/requirements.txt
.config.default.yaml
andconfig.tutorial.yaml
.test/
(note tests are changing the config.tutorial.yaml)doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.