Revise TODOs in add_electricity: enable offshore wind and revise hydro

[davide-f]

Closes #713

Changes proposed in this Pull Request

This PR aims at:

• re-introducing offshore wind technologies in the workflow
• revise the hydro implementation to better handle the max_hours definition that was not accurate

This also partially cover #760

Checklist

• I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
• I tested my contribution locally and it seems to work fine.
• Code and workflow changes are sufficiently documented.
• Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
• Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
• Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
• Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
• A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

[davide-f]

@hazemakhalek this PR partially handles some issues on hydro: calculate max_hours by country stats. It doesn't fix the problem of placing the same time series on units of the same hydro power plant
FYI: @carlosfv92 , @ekatef

@energyLS this PR should handle the offshore wind ac and dc

[ekatef]

@davide-f amazing work! That is great that you have returned back off-wind :)

Have added some little comments. I also wonder if it'd be possible to use a configuration parameter for the default hydro_max_hours instead of 6 which is hardcoded currently:

pypsa-earth/scripts/add_electricity.py

Lines 580 to 582 in a1583bc

	hydro_max_hours = hydro.max_hours.where(
	hydro.max_hours > 0, hydro.country.map(max_hours_country)
	).fillna(6)

Actually, we have PHS_max_hours, but my feeling is that it would be even more handy having to have such a parameter for reservoir plants explicitly declared. What is your feeling about that?

[ekatef]

Could it make sense to specify here lower argument explicitly, as it's done above:

pypsa-earth/scripts/add_electricity.py

Line 556 in a1583bc

e_target = hydro_stats["E_store[TWh]"].clip(lower=0.2) * 1e6

[davide-f]

Good idea!

[davide-f]

@davide-f amazing work! That is great that you have returned back off-wind :)

Have added some little comments. I also wonder if it'd be possible to use a configuration parameter for the default hydro_max_hours instead of 6 which is hardcoded currently:

pypsa-earth/scripts/add_electricity.py

Lines 580 to 582 in a1583bc

	hydro_max_hours = hydro.max_hours.where(
	hydro.max_hours > 0, hydro.country.map(max_hours_country)
	).fillna(6)

Actually, we have PHS_max_hours, but my feeling is that it would be even more handy having to have such a parameter for reservoir plants explicitly declared. What is your feeling about that?

Hello :)
All changes are implemented :)

[ekatef]

@davide-f amazing work! That is great that you have returned back off-wind :)
Have added some little comments. I also wonder if it'd be possible to use a configuration parameter for the default hydro_max_hours instead of 6 which is hardcoded currently:

pypsa-earth/scripts/add_electricity.py

Lines 580 to 582 in a1583bc

	hydro_max_hours = hydro.max_hours.where(
	hydro.max_hours > 0, hydro.country.map(max_hours_country)
	).fillna(6)

Actually, we have PHS_max_hours, but my feeling is that it would be even more handy having to have such a parameter for reservoir plants explicitly declared. What is your feeling about that?

Hello :) All changes are implemented :)

Hello @davide-f :) Added a little additional suggestion. Otherwise looks perfect, I think :)

Great work!

[davide-f]

Added a comment, I think we could go as is, I'd merge, if you disagree, feel free to revise at next occasion :D