Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unknown attributes breaking packet init #107

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix unknown attributes breaking packet init #107

wants to merge 4 commits into from

Commits on Apr 5, 2019

  1. Adds simple test case exposing issue pyradius#87 with unknown attributes 

    ======================================================================
ERROR: testDecodePacketWithUnknownAttribute (tests.testPacket.PacketTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/testPacket.py", line 337, in testDecodePacketWithUnknownAttribute
    six.b('\x01\x02\x00\x1b1234567890123456\x09\x07value'))
  File "/Users/user/pyrad/pyrad/packet.py", line 415, in DecodePacket
    elif self.dict.attributes[self._DecodeKey(key)].type == 'tlv':
KeyError: 9
    @twschum
    twschum committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    ce41647 View commit details
    Browse the repository at this point in the history

  2. Adds realistic raw packet and dictfile

    @twschum
    twschum committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    e1cde9a View commit details
    Browse the repository at this point in the history

  3. Use a KeyError safe function to test for TLV attribute

    @twschum
    twschum committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    fdfcd60 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2019

  1. Merge branch 'master' into fix-unknown-attributes-breaking-packet-init

    @twschum
    twschum authored Oct 22, 2019
    Configuration menu
    Copy the full SHA
    0c68641 View commit details
    Browse the repository at this point in the history