Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forms.show_balloon() first prototype [forms module] #1801

Merged
merged 5 commits into from
Apr 20, 2023
Merged

forms.show_balloon() first prototype [forms module] #1801

merged 5 commits into from
Apr 20, 2023

Conversation

jmcouffin
Copy link
Contributor

first hint from Konstantin (https://github.com/nodatasheet)

image

@jmcouffin jmcouffin added Enhancement Enhancement request [class->Improved #{number}: {title}] Prioritize The issue is planned to be resolved in the next version Tools Issues related to pyRevit commands [subsystem] labels Apr 19, 2023
@jmcouffin
Copy link
Contributor Author

@thumDer Care to test and improve?

@jmcouffin
Copy link
Contributor Author

@alexdaversa Care to test and improve?

@jmcouffin jmcouffin changed the title Show balloon first prototype to forms module forms.show_balloon() first prototype [forms module] Apr 19, 2023
@jmcouffin
Copy link
Contributor Author

Tested
Basic implementation could be pimped adding support for more complex content including xaml layout handling

@jmcouffin jmcouffin merged commit 9ff5072 into pyrevitlabs:develop Apr 20, 2023
@jmcouffin jmcouffin deleted the show-balloon branch April 20, 2023 07:56
@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23110+0800-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23111+0822-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23114+0751-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23114+0900-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23117+1019-wip

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

📦 New work-in-progress (wip) builds are available for 4.8.13.23122+0740-wip

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2023

📦 New work-in-progress (wip) builds are available for 4.8.13.23126+1635-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23131+1009-wip

@saurabhsjha
Copy link

Tests.pulldown\Forms Module Tests.pushbutton\script.py", line 41, in
NameError: name 'result_item_result_clicked' is not defined

@saurabhsjha
Copy link

saurabhsjha commented May 16, 2023 •
edited
Loading

when i trying " forms.show_balloon("my header", "Lorem ipsum", tooltip='tooltip', group='group', is_favourite=True, is_new=True, timestamp = '2019-01-01 00:00:00', click_result = forms.result_item_result_clicked)" it gives error File "C:\Users\saurabh.j\AppData\Roaming\pyRevit-Master\pyrevitlib\pyrevit\forms_init_.py", line 2862, in show_balloon
TypeError: expected DateTime, got str -----putting timestamp None works

@jmcouffin jmcouffin mentioned this pull request May 17, 2023
Merged
@jmcouffin
Copy link
Contributor Author

Tests.pulldown\Forms Module Tests.pushbutton\script.py", line 41, in NameError: name 'result_item_result_clicked' is not defined

without this specific code, hard to tell.

@jmcouffin
Copy link
Contributor Author

when i trying " forms.show_balloon("my header", "Lorem ipsum", tooltip='tooltip', group='group', is_favourite=True, is_new=True, timestamp = '2019-01-01 00:00:00', click_result = forms.result_item_result_clicked)"

you are right, the example was of, I forgot to indicate that the Timestamp needed to be of type 'date'

converting the string to date like so:

date = '2019-01-01 00:00:00'
date = datetime.datetime.strptime(date, '%Y-%m-%d %H:%M:%S')

or using datetime.datetime.now() dos the trick

@jmcouffin
Copy link
Contributor Author

and thanks @saurabhsjha for giving it a try

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23137+0756-wip

@jmcouffin
Copy link
Contributor Author

I also fixed the unit test.
Wait for the next wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23137+0809-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23139+0632-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23144+0857-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23144+0943-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23144+0957-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23144+1030-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23161+1332-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+0849-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+0858-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+0910-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+0908-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+1046-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+1150-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+1153-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23164+0946-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23165+1014-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23166+0843-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23170+0833-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23170+1018-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23170+1041-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23177+1038-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23181+1652-wip

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

📦 New public release are available for 4.8.13.23182+2215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement Enhancement request [class->Improved #{number}: {title}] Prioritize The issue is planned to be resolved in the next version Tools Issues related to pyRevit commands [subsystem]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcouffin @saurabhsjha