Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invokebutton #1931

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Fix invokebutton #1931

merged 2 commits into from
Sep 30, 2023

Conversation

dosymep
Copy link
Member

@dosymep dosymep commented Sep 29, 2023

I fixed a bug with the assembly cache that I introduced in the last PR.

Wrong bundle config

was
image

became
image

@dosymep
Copy link
Member Author

dosymep commented Sep 29, 2023

This PR added wrong work with InvokeButton.

I don't know what InvokeDLLEngine one for all assemblies, there was also a code that misled me.

#1777

@dosymep
Copy link
Member Author

dosymep commented Sep 29, 2023

Maybe I broke everything 😔

@jmcouffin
Copy link
Contributor

Let's try it then

@jmcouffin jmcouffin closed this Sep 30, 2023
@jmcouffin jmcouffin reopened this Sep 30, 2023
@jmcouffin jmcouffin merged commit 50e361b into pyrevitlabs:develop Sep 30, 2023
@jmcouffin jmcouffin added Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class] Runtime Issues related to loading pyRevit runtime [subsystem] Engines Issues related to pyRevit execution engines [subsystem] labels Sep 30, 2023
@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23273+0712-wip

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

📦 New work-in-progress (wip) builds are available for 4.8.14.23276+0814-wip

@dosymep dosymep deleted the fix_invokebutton branch October 4, 2023 10:24
@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23289+0854-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23290+1050-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23290+1104-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23291+0959-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23291+1028-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23291+1125-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23293+0837-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23293+1010-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23293+1303-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23295+2104-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23295+2132-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23296+0902-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23299+1941-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23304+0918-wip

Copy link
Contributor

github-actions bot commented Nov 6, 2023

📦 New work-in-progress (wip) builds are available for 4.8.14.23310+1210-wip

Copy link
Contributor

github-actions bot commented Nov 9, 2023

📦 New work-in-progress (wip) builds are available for 4.8.14.23313+1353-wip

Copy link
Contributor

github-actions bot commented Nov 9, 2023

📦 New work-in-progress (wip) builds are available for 4.8.14.23313+1412-wip

Copy link
Contributor

github-actions bot commented Nov 9, 2023

📦 New work-in-progress (wip) builds are available for 4.8.14.23313+2035-wip

Copy link
Contributor

github-actions bot commented Nov 9, 2023

📦 New work-in-progress (wip) builds are available for 4.8.14.23313+2133-wip

Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23326+1241-wip

Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23326+2020-wip

Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23327+1037-wip

Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23328+0920-wip

Copy link
Contributor

github-actions bot commented Dec 1, 2023

📦 New work-in-progress (wip) builds are available for 4.8.14.23335+1813-wip

Copy link
Contributor

github-actions bot commented Dec 4, 2023

📦 New work-in-progress (wip) builds are available for 4.8.14.23338+0813-wip

Copy link
Contributor

github-actions bot commented Dec 6, 2023

📦 New work-in-progress (wip) builds are available for 4.8.14.23340+1759-wip

Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23346+0717-wip

Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23352+1117-wip

Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23352+1544-wip

Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23353+1120-wip

Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23353+1222-wip

Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23354+0922-wip

Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23354+1019-wip

Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.23354+1055-wip

Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.14.24012+1924-wip

Copy link
Contributor

📦 New public release are available for 4.8.14.24016+1909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class] Engines Issues related to pyRevit execution engines [subsystem] Runtime Issues related to loading pyRevit runtime [subsystem]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants