Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Finitary funsor for representing lazy op application #423

Merged
merged 10 commits into from
Feb 23, 2021
Merged

Add Finitary funsor for representing lazy op application #423

merged 10 commits into from
Feb 23, 2021

Conversation

eb8680
Copy link
Member

@eb8680 eb8680 commented Jan 12, 2021 •
edited
Loading

Addresses #351. Blocked by #421, #422.

This PR adds a new term funsor.terms.Finitary that represents lazy op application, and refactors funsor.terms.Einsum into a new op EinsumOp that makes use of the find_domain extensibility added in #422.

Tested:

  • Exercised a bit by existing Einsum tests

@eb8680 eb8680 added Blocked Blocked by other issues WIP refactor labels Jan 12, 2021
@eb8680 eb8680 force-pushed the singledispatch-find-domain branch 2 times, most recently from a99c429 to 538fdb8 Compare January 13, 2021 23:35
fritzo
fritzo approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@fritzo fritzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from singledispatch-find-domain to master January 14, 2021 00:59
@eb8680 eb8680 removed the Blocked Blocked by other issues label Jan 14, 2021
@eb8680 eb8680 mentioned this pull request Jan 14, 2021
Open
21 tasks
@eb8680 eb8680 mentioned this pull request Jan 20, 2021
Closed
eb8680
eb8680 commented Jan 20, 2021
View reviewed changes
funsor/tensor.py Outdated Show resolved Hide resolved
@eb8680 eb8680 mentioned this pull request Feb 3, 2021
Merged
4 tasks
@eb8680 eb8680 requested a review from fritzo February 23, 2021 15:14
fritzo
fritzo approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@fritzo fritzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great simplification!

Only one nit on keeping the standard np.einsum interface

test/test_distribution.py Outdated Show resolved Hide resolved
funsor/tensor.py Outdated Show resolved Hide resolved
@eb8680 eb8680 merged commit 0344765 into master Feb 23, 2021
@eb8680 eb8680 deleted the finitary-funsor branch February 23, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzo fritzo fritzo approved these changes

Assignees
No one assigned
Labels
awaiting review refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eb8680 @fritzo