Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise NotImplementedError rather than return it. #1732

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

tillahoffmann
Copy link
Contributor

The forward transform of the Transform base class and summary statistics of truncated distributions return rather than raise exceptions. This PR ensures exceptions are raised.

Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow what a bug. thanks for the fix!

@fehiepsi fehiepsi merged commit 83ebecc into pyro-ppl:master Feb 7, 2024
4 checks passed
@tillahoffmann tillahoffmann deleted the raise branch February 7, 2024 22:42
OlaRonning pushed a commit to aleatory-science/numpyro that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants