-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing nested sampling #1871
Fixing nested sampling #1871
Conversation
could you update jaxns version in setup and docs/requirements Line 64 in 8e9313f
|
bd16aab
to
5076a40
Compare
@fehiepsi any idea on how to enforce double precision in the test base for this specific test ? I don't know how JAX and pytest work together and if it is possible to enable x64 for a single test |
You can add a flag like this one numpyro/.github/workflows/ci.yml Line 111 in 8e9313f
|
f5785e1
to
6c21533
Compare
6c21533
to
0c42f8e
Compare
Okay I hope it works now, I had a lot of trouble since latest versions of
|
19ae8f0
to
1a2b59c
Compare
1a2b59c
to
8dcfe2a
Compare
Okay @fehiepsi this should work now. For you to know, most of the struggles came from the fact that importing |
I think it's ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo, thanks @renecotyfanboy!
There are some import discrepancies between
jaxns<2.6
andjaxns 2.6.*
. This small fix seems to do the trick!