Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the forecasting with the usage of Predictive #608

Merged
merged 7 commits into from
May 27, 2020

Conversation

fehiepsi
Copy link
Member

Originally, we wrote the tutorial to introduce some handlers and the usage of vmap to forecast values. But for many cases, we don't need to learn about handlers to use NumPyro. So this PR adds a small section to illustrate that we can use Predictive utility to get the same result with just 2 lines of code.

@neerajprad
Copy link
Member

This looks good. If we have introduced effect handlers in other tutorials, I am fine with even removing the whole forecasting part and using Predictive by default if that keeps things simple.

@fehiepsi
Copy link
Member Author

Yeah, you are right. We already covered handlers in regression tutorial. Let me remove that part.

@neerajprad neerajprad merged commit dfa00ff into pyro-ppl:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants