Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SoftLaplace.mean, .variance properties #2800

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Add SoftLaplace.mean, .variance properties #2800

merged 1 commit into from
Apr 9, 2021

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Apr 8, 2021

Port of pyro-ppl/numpyro#1002

Tested

  • added a new test_mean() which is run on all standard distributions
  • added a new test_variance() which is run on all standard distributions

@fritzo fritzo requested a review from fehiepsi April 8, 2021 23:10
fehiepsi
fehiepsi approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fehiepsi fehiepsi merged commit 70142ca into dev Apr 9, 2021
@fritzo fritzo mentioned this pull request Jul 5, 2021
Merged
@fritzo fritzo deleted the soft-laplace-moments branch September 27, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fehiepsi fehiepsi fehiepsi approved these changes

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fritzo @fehiepsi