Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ruff version to 0.3.4 in order to overcome issue with version 0.3.5. #3354

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

BenZickel
Copy link
Contributor

  • Linting with ruff version 0.3.5 fails as can be seen here.
  • The failure is due to ruff version 0.3.5 not respecting this directive.
  • The problem does not occur with ruff version 0.3.4.

Copy link
Member

@fritzo fritzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BenZickel! Do you have any idea how to get ruff>=0.3.5 to respect __all__?

@BenZickel
Copy link
Contributor Author

Hi @fritzo! I think the issue is that ruff 0.3.5 is not respecting the # noqa: F822 directive for all lines of a multiline expression, while ruff 0.3.4 does. I will open an issue in the ruff repo and based on the feedback I get we can decide how to fix this.
This pull request is just a hotfix in the meantime.

@fritzo fritzo merged commit 725b135 into pyro-ppl:dev Apr 5, 2024
9 checks passed
@BenZickel BenZickel mentioned this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants