Feature/switch to reolink cam #78
Conversation
| version: '3.8' | ||
|
|
||
| services: | ||
| pyro-engine: | ||
| build: | ||
| context: .. | ||
| dockerfile: ./runner/src/Dockerfile | ||
| command: python runner.py | ||
| volumes: | ||
| - ./data:/usr/src/app/data | ||
|
|
||
| restart: always |
There was a problem hiding this comment.
Considering the simplicity of this, we might consider in the future to run it as a simple docker (not a docker compose)
There was a problem hiding this comment.
We can leave it as it is for know and discuss it soon :)
MateoLostanlen
force-pushed
the
feature/switch_to_reolink_cam
branch
from
14f4dde to
a067b94
Compare
Codecov Report
@@ Coverage Diff @@
## develop #78 +/- ##
===========================================
- Coverage 68.12% 67.67% -0.45%
===========================================
Files 7 7
Lines 229 232 +3
===========================================
+ Hits 156 157 +1
- Misses 73 75 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
I will improve coverage when #83 will be merge |
|
The loss of coverage here is on engine but you would have to simulate an api or create test creds to test it. I propose to do it in a next PR |
|
Let's merge this |
frgfm
added
type: new feature
ext: src
topic: docker
module: engine
and removed
type: enhancement
The purpose of this PR is to adapt pyro-engine to our camera change. We are now going to use reolink ip cameras.
Previously the central raspberry pi was behaving like a server with an api, the ip cameras sent every 30s an image to this api for analysis.
Now the cameras are passive and it's the central pi that will fetch the images for analysis.