Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop useless files #80

Merged
merged 4 commits into from
Jul 19, 2022

Conversation

MateoLostanlen
Copy link
Member

The aim of this PR is to do a bit of cleaning:

  1. we are not using pizeros so pizeros related files are removed
  2. We are not usiing a wifi routeur so routeur related files / elements are removed too
  3. Drop useless one test

@MateoLostanlen MateoLostanlen self-assigned this Jul 18, 2022
@MateoLostanlen MateoLostanlen added the invalid This doesn't seem right label Jul 18, 2022
@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #80 (53ce9c5) into develop (6565aaa) will decrease coverage by 3.91%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop      #80      +/-   ##
===========================================
- Coverage    68.12%   64.20%   -3.92%     
===========================================
  Files            7        5       -2     
  Lines          229      176      -53     
===========================================
- Hits           156      113      -43     
+ Misses          73       63      -10     
Flag Coverage Δ
unittests 64.20% <ø> (-3.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyroengine/pi_utils/monitor_pi.py 91.17% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6565aaa...53ce9c5. Read the comment docs.

@MateoLostanlen MateoLostanlen requested review from fe51 and frgfm July 18, 2022 14:49
@MateoLostanlen
Copy link
Member Author

I will improve coverage when #83 will be merge

Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I wasn't sure about the router reboot check though

@MateoLostanlen MateoLostanlen requested a review from frgfm July 19, 2022 16:53
Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MateoLostanlen MateoLostanlen merged commit 54c119d into pyronear:develop Jul 19, 2022
@MateoLostanlen MateoLostanlen deleted the drop_useless_files branch July 24, 2022 17:21
@frgfm frgfm added type: breaking change and removed invalid This doesn't seem right labels Aug 7, 2022
@frgfm frgfm added this to the 0.2.0 milestone Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants