fix: Fixed import for torch 1.10 release

[MateoLostanlen]

Small PR to fix our unitest

The function load_state_dict_from_url is now part of torch.hub

We need to update the import accordingly

We must therefore set the minimal version of pytorch to 1.10

[MateoLostanlen]

I wonder if setting the minimal version of pytorch to the last release is not too restrictive. @frgfm what do you think ?

It seems you have the same issue in holocron :)

[frgfm]

I wonder if setting the minimal version of pytorch to the last release is not too restrictive. @frgfm what do you think ?

It seems you have the same issue in holocron :)

Yup I agree, either I update it or do a conditional import by checking the library version 👍

Considering 0.10.0 is brand new, either we decide to:

• update it because there are features that we consider critical in this release
• add an upper constraint (<0.10.0)
• make the import conditional

I would go for the latter in this situation 👍

[MateoLostanlen]

It seems to be the best solution indeed, I opened a PR on holocron to solve the problem.

[frgfm]

Actually the function is available in PyTorch since 1.1.0 (https://github.com/pytorch/pytorch/blob/v1.1.0/torch/hub.py#L385), and torchvision was only making a mirror for it up until the last release! So we only need:

from torch.hub import load_state_dict_from_url

[MateoLostanlen]

Hi @frgfm, thanks for catching this !

[frgfm]

Thanks for the edits!

[frgfm]

About the unittest crash, I'll make a release of Holocron rather soon, we'll need to update the version constraint ;)

[MateoLostanlen]

About the unittest crash, I'll make a release of Holocron rather soon, we'll need to update the version constraint ;)

Ok Let me know when it's done I will wait to go further with this PR and set holocron minimal requirement (0.1.4 I guess).

[frgfm]

About the unittest crash, I'll make a release of Holocron rather soon, we'll need to update the version constraint ;)

Ok Let me know when it's done I will wait to go further with this PR and set holocron minimal requirement (0.1.4 I guess).

To avoid waiting for the release, I suggest switching all pylocron requirements (here and here) from

pylocron>=0.1.3

to

-e git+https://github.com/frgfm/Holocron.git#egg=pylocron

This will install the latest version from the git master branch instead of the release 👍

[MateoLostanlen]

Hi @frgfm, unfortunately we can' t use e git+https://github.com/frgfm/Holocron.git#egg=pylocron in setup.py. A simple solution while waiting for the new holocron release is to install the requirements and then the package as I do here.

The problem seems to be solved for the moment.

Only one test doesn't pass but it's always the same problem of openfire which has less and less image available. This problem will be solved after the merge of #121

[frgfm]

Thanks! I added a few suggestions

[MateoLostanlen]

Hi @frgfm, I think you did not understand. I propose here a temporary fix while you make your release because it blocks the pr on vision and engine for the moment. This modification allows to install holocron from the repo without waiting for the release. So you can take your time :)

[MateoLostanlen]

ah ok you release 0.2.0, I will make the change then

[MateoLostanlen]

all good :)

[frgfm]

All good!