Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore version file #137

Merged
merged 1 commit into from
Mar 15, 2022
Merged

ignore version file #137

merged 1 commit into from
Mar 15, 2022

Conversation

MateoLostanlen
Copy link
Member

Because version file if generated from setup, maybe it's cleaner to ignore it to avoid a useless untracked file

@MateoLostanlen MateoLostanlen added the invalid This doesn't seem right label Mar 13, 2022
@MateoLostanlen MateoLostanlen requested a review from frgfm March 13, 2022 15:22
@MateoLostanlen MateoLostanlen self-assigned this Mar 13, 2022
frgfm
frgfm approved these changes Mar 13, 2022
View reviewed changes
Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@MateoLostanlen MateoLostanlen merged commit 2dcf667 into pyronear:master Mar 15, 2022
@MateoLostanlen MateoLostanlen deleted the ignore_version branch March 17, 2022 19:44
@frgfm frgfm added type: bug Something isn't working topic: build Related to build and installation and removed invalid This doesn't seem right labels Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frgfm frgfm frgfm approved these changes

Assignees

@MateoLostanlen MateoLostanlen

Labels
topic: build Related to build and installation type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MateoLostanlen @frgfm