Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactored package for incoming v0.2 #138

Merged
merged 27 commits into from
May 20, 2022
Merged

refactor: Refactored package for incoming v0.2 #138

merged 27 commits into from
May 20, 2022

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented May 19, 2022

This PR introduces the following modifications:

  • adds proper code quality config (isort, mypy, flake8, pydocstyle)
  • updates issue templates
  • adds CI job for header & requirement verifications
  • adds CI job for code quality verification
  • adds code of conduct
  • removes pyrovision.nn
  • refactored models : removes ssresnet, densenet, mobilenetv2 / adds mobilenetv3
  • switched test suite from unittest to pytest
  • removes legacy documentation sections
  • updates classification training script

The goal of this PR is to help speed up iterations by R&D teams. PyroVision is not meant primarily for model exploration, Pyronear curates and provides relevant data, and model that will be trained on them. Thus features for model modification have been deprecated. Next PR will focus on checkpoint sharing and loading via HF Hub!

Any feedback is welcome!

@frgfm frgfm added type: enhancement New feature or request ext: tests Related to tests module: models Related to models ext: references Related to references module: datasets Related to datasets labels May 19, 2022
@frgfm frgfm added this to the 0.2.0 milestone May 19, 2022
@frgfm frgfm requested a review from a team May 19, 2022 14:53
@frgfm frgfm self-assigned this May 19, 2022
@frgfm frgfm mentioned this pull request May 19, 2022
12 tasks
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #138 (244952c) into master (40ddf2f) will decrease coverage by 3.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
- Coverage   92.33%   89.16%   -3.17%     
==========================================
  Files          18        8      -10     
  Lines         652      203     -449     
==========================================
- Hits          602      181     -421     
+ Misses         50       22      -28     
Flag Coverage Δ
unittests 89.16% <100.00%> (-3.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyrovision/datasets/__init__.py 100.00% <ø> (ø)
pyrovision/datasets/openfire.py 91.56% <100.00%> (+0.54%) ⬆️
pyrovision/datasets/utils.py 77.61% <100.00%> (-13.16%) ⬇️
pyrovision/models/__init__.py 100.00% <100.00%> (ø)
pyrovision/models/mobilenetv3.py 100.00% <100.00%> (ø)
pyrovision/models/resnet.py 100.00% <100.00%> (+17.39%) ⬆️
pyrovision/models/rexnet.py 100.00% <100.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce4db67...244952c. Read the comment docs.

@frgfm frgfm merged commit 48262ca into master May 20, 2022
@frgfm frgfm deleted the revamp branch May 20, 2022 10:43
@MateoLostanlen
Copy link
Member

our current model used by pyro-engine was based on this architecture it not possible to load the model anymore now :/

@frgfm
Copy link
Member Author

frgfm commented May 25, 2022

Yes, that's why the release is on hold while we haven't published new sets of params 👍 Sorry about the incovenience!

To use the previous one, one can checkout the commit right before this one. But the goal is to make everything clean for 0.2.0. I still need to retrain our baseline on those architectures and publish it

If you have training undergoing, I'd suggest using the updated scripts & architectures (should get better perf) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: references Related to references ext: tests Related to tests module: datasets Related to datasets module: models Related to models module: nn Related to nn topic: build Related to build and installation topic: ci type: breaking change type: code quality type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants