Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixed URL in CONTRIBUTING #141

Merged
merged 1 commit into from
Jun 8, 2022
Merged

docs: Fixed URL in CONTRIBUTING #141

merged 1 commit into from
Jun 8, 2022

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented Jun 8, 2022

This PR fixes a broken URL in CONTRIBUTING.

Any feedback is welcome!

@frgfm frgfm added the topic: documentation Improvements or additions to documentation label Jun 8, 2022
@frgfm frgfm added this to the 0.2.0 milestone Jun 8, 2022
@frgfm frgfm requested a review from a team June 8, 2022 12:54
@frgfm frgfm self-assigned this Jun 8, 2022
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #141 (2c3312d) into master (48262ca) will not change coverage.
The diff coverage is n/a.

❗ Current head 2c3312d differs from pull request most recent head 361d158. Consider uploading reports for the commit 361d158 to get more accurate results

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   89.16%   89.16%           
=======================================
  Files           8        8           
  Lines         203      203           
=======================================
  Hits          181      181           
  Misses         22       22           
Flag Coverage Δ
unittests 89.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48262ca...361d158. Read the comment docs.

@frgfm
Copy link
Member Author

frgfm commented Jun 8, 2022

The CI job is doing weird things: the two other links mention do work. They're redirecting to something else and if I change it to the end URL, it still fails 🤷‍♂️

So I'll leave it as is

@frgfm frgfm merged commit c411ac4 into master Jun 8, 2022
@frgfm frgfm deleted the url-fix branch June 8, 2022 13:22
@frgfm frgfm added the type: bug Something isn't working label Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Improvements or additions to documentation type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant