Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Updated header verification, env collection and docker job #147

Merged
merged 4 commits into from
Jul 13, 2022

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented Jul 4, 2022

This PR introduces the following modifications:

  • updates the env collection script for Windows
  • updates the docker job
  • updates the header verification job & the corresponding headers

Any feedback is welcome!

@frgfm frgfm added topic: documentation Improvements or additions to documentation type: enhancement New feature or request topic: ci labels Jul 4, 2022
@frgfm frgfm added this to the 0.2.0 milestone Jul 4, 2022
@frgfm frgfm requested a review from a team July 4, 2022 21:09
@frgfm frgfm self-assigned this Jul 4, 2022
@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #147 (43f2d23) into master (eee9e54) will increase coverage by 0.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage   89.16%   89.65%   +0.49%     
==========================================
  Files           8        8              
  Lines         203      203              
==========================================
+ Hits          181      182       +1     
+ Misses         22       21       -1     
Flag Coverage Δ
unittests 89.65% <ø> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyrovision/datasets/openfire.py 91.56% <ø> (ø)
pyrovision/datasets/utils.py 79.10% <ø> (+1.49%) ⬆️
pyrovision/models/mobilenetv3.py 100.00% <ø> (ø)
pyrovision/models/resnet.py 100.00% <ø> (ø)
pyrovision/models/rexnet.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eee9e54...43f2d23. Read the comment docs.

@frgfm frgfm merged commit 5121b14 into master Jul 13, 2022
@frgfm frgfm deleted the ci-update branch July 13, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: ci topic: documentation Improvements or additions to documentation type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant