feat: Add argument img_folder to OpenFire #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the discussion in pyronear#26, add argument (str or Path) to OpenFire. If not given, the default is used. The rest of the folder structure is kept for the moment. test_datasets.py now tests its type and also if the download succeeded approximately: up to 10 samples can be missing.
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
==========================================
+ Coverage 86.25% 86.53% +0.27%
==========================================
Files 21 21
Lines 866 869 +3
==========================================
+ Hits 747 752 +5
+ Misses 119 117 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
frgfm
reviewed
Oct 22, 2019
frgfm
reviewed
Oct 22, 2019
frgfm
reviewed
Oct 22, 2019
frgfm
requested changes
Oct 22, 2019
frgfm
added
type: enhancement
Following comments on pyronear#32: - Avoiding long lines, also splitting if / else in OpenFire c-tor - Changing style and adding test on default img_folder value in test_datasets.py
frgfm
reviewed
Oct 22, 2019
frgfm
previously approved these changes
Oct 23, 2019
Adding argument --img-folder to fastai/train.py and torch/train.py
|
@blenzi Just checking, is this still on? Or was it covered by another PR recently? |
This branch remained idle for a long time. Trying to merge with frgfm/master. Short summary of new features: - Adding argument img_folder to OpenFire c-tor, stored in img_folder attribute (default to previous value: root/OpenFire/images) and returned by _images property - Adding argument --img-folder to fastai/train.py and torch/train.py - Associated tests
frgfm
previously approved these changes
May 22, 2020
|
@blenzi : Do you need any help to resolve the conflicts ? |
|
Mind trying to solve the conflicts @blenzi 🙏 ? (the scripts were moved, just need some fixing) |
added 2 commits
September 25, 2020 17:49
In test_datasets.py/DatasetsTester.test_openfire: allow up to 15 failed downloads instead of 10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in #26, add argument img_folder (str or Path) to OpenFire. If not given, the default
<root>/OpenFire/imagesis used. The rest of the folder structure is kept for the moment.test_datasets.py now tests its type and also if the download succeeded approximately: up to 10 samples can be missing.