fix(flamegraph): table, buttons colors for light mode #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## main #1458 +/- ##
=======================================
Coverage 68.51% 68.51%
=======================================
Files 129 129
Lines 4290 4290
Branches 1159 1159
=======================================
Hits 2939 2939
Misses 1345 1345
Partials 6 6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pavelpashkovsky
changed the title
eh-am
reviewed
Sep 5, 2022
| @@ -5,6 +5,10 @@ | |||
| align-items: center; | |||
| } | |||
|
|
|||
| .navbar button { | |||
| color: var(--ps-neutral-2); | |||
There was a problem hiding this comment.
Would be nice to define that somewhat globally no? Since it's clear this color applies app-wide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief
Fix incorrect colors for UI elements on Flamegraph for light mode.
Changes
before:
after:
Concerns
sanitize.cssre-writes assigned styles