Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flamegraph): table width #1463

Merged
merged 2 commits into from
Sep 6, 2022
Merged

fix(flamegraph): table width #1463

merged 2 commits into from
Sep 6, 2022

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Sep 6, 2022

If users of the flamegraph component have table { display: block; }, the tooltip table won't expand to full width:

Screen Shot 2022-09-06 at 10 21 56

Screen Shot 2022-09-06 at 10 22 05

Forcing the default fixes the issue.

Also updated docs to use newest API (profile instead of flamebearer)

@eh-am eh-am marked this pull request as ready for review September 6, 2022 13:23
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 419.27 KB (0%) 8.4 s (0%) 4.3 s (+12.49% 🔺) 12.6 s
webapp/public/assets/app.css 15.5 KB (+0.05% 🔺) 310 ms (+0.05% 🔺) 0 ms (+100% 🔺) 310 ms
webapp/public/assets/styles.css 9.47 KB (0%) 190 ms (0%) 0 ms (+100% 🔺) 190 ms
packages/pyroscope-flamegraph/dist/index.js 91.8 KB (0%) 1.9 s (0%) 2 s (+3.47% 🔺) 3.9 s
packages/pyroscope-flamegraph/dist/index.node.js 91.65 KB (0%) 1.9 s (0%) 755 ms (+25.51% 🔺) 2.6 s
packages/pyroscope-flamegraph/dist/index.css 7.12 KB (+0.1% 🔺) 143 ms (+0.1% 🔺) 0 ms (+100% 🔺) 143 ms

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #1463 (f4fbf05) into main (0869986) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1463   +/-   ##
=======================================
  Coverage   68.51%   68.51%           
=======================================
  Files         129      129           
  Lines        4290     4290           
  Branches     1159     1159           
=======================================
  Hits         2939     2939           
  Misses       1345     1345           
  Partials        6        6           
Impacted Files Coverage Δ
...roscope-flamegraph/src/Tooltip/Tooltip.module.scss 61.54% <ø> (ø)
webapp/javascript/ui/Notifications.tsx 39.48% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm thx!

@Rperry2174 Rperry2174 merged commit f19b8ac into main Sep 6, 2022
@Rperry2174 Rperry2174 deleted the fix/flamegraph-table-width branch September 6, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants